Clean up UI for checking for duplicate emails during account creation #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willgearty
reviewed
Apr 3, 2024
There was a problem hiding this comment.
This looks great, thanks @kkbrum! Just one question, then it can be merged.
Comment on lines
332
to
335
| padding-top: 9px; | ||
| margin-left: auto; | ||
| margin-right: auto; | ||
| display: block; |
There was a problem hiding this comment.
Why did you make these changes to the logo styling?
There was a problem hiding this comment.
oops that must be residual from working on the logo centering PR at a similar time. I'll fix that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118. I made it such that emails are only considered duplicates if they want to make a user account of the same type. This hopefully addresses the concern of a student using a parent email and the parent also wanting a guardian account using the same email. I also removed the first and last names from being displayed, since that feels like a bit of a privacy issue. I also changed the default tag setting to check for duplicate emails.