Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: protect Fin.cast and BitVec.cast #6315

Merged
merged 2 commits into from
Dec 5, 2024
Merged

chore: protect Fin.cast and BitVec.cast #6315

merged 2 commits into from
Dec 5, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Dec 5, 2024

This PR adds protected to Fin.cast and BitVec.cast, to avoid confusion with _root_.cast. These should mostly be used via dot-notation in any case.

@kim-em kim-em added awaiting-mathlib We should not merge this until we have a successful Mathlib build changelog-library Library labels Dec 5, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 5, 2024 02:02 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 5, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 5, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6315
00f38fa
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 5, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6315
aff4255
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 5, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 5, 2024 •
edited
Loading

Mathlib CI status (docs):

kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 5, 2024
@kim-em
fixes for leanprover/lean4#6315
ef15654
@kim-em kim-em removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Dec 5, 2024
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 5, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 5, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 5, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6315
d11f6d3
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 5, 2024 02:56 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 5, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6315
8f14f4f
@kim-em kim-em mentioned this pull request Dec 5, 2024
Merged
@kim-em kim-em added this pull request to the merge queue Dec 5, 2024
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 5, 2024
@kim-em
fixes for leanprover/lean4#6315
60471f8
Merged via the queue into master with commit 019f8e1 Dec 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasgrosser tobiasgrosser tobiasgrosser approved these changes

Assignees
No one assigned
Labels
awaiting-mathlib We should not merge this until we have a successful Mathlib build breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-em @leanprover-community-bot @tobiasgrosser