Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: CMAKE_CXX_SYSROOT_FLAG is also needed for linking #6297

Merged
merged 2 commits into from
Dec 3, 2024
Merged

chore: CMAKE_CXX_SYSROOT_FLAG is also needed for linking #6297

merged 2 commits into from
Dec 3, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Dec 3, 2024 •
edited
Loading

Fixes #6296

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 3, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-12-03 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-12-03 09:38:45)

@Kha Kha added the release-ci Enable all CI checks for a PR, like is done for releases label Dec 3, 2024
@zwarich
Copy link
Contributor

zwarich commented Dec 3, 2024

This fixes the problem for me.

@Kha Kha added this pull request to the merge queue Dec 3, 2024
Merged via the queue into leanprover:master with commit 2a891a3 Dec 3, 2024
27 checks passed
@Kha Kha deleted the push-wmuoymknymqw branch December 4, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invocations of C++ compiler by Lake tests don't pass -isysroot on macOS
3 participants
@Kha @leanprover-community-bot @zwarich