Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove runtime bounds checks and partial from qsort #6241

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Nov 28, 2024

This PR refactors Array.qsort to remove runtime array bounds checks, and avoids the use of partial. We use the Vector API, along with auto_params, to avoid having to write any proofs. The new code benchmarks indistinguishably from the old.

@kim-em kim-em added the changelog-library Library label Nov 28, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 28, 2024 00:55 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 28, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 28, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 88e3a2b1ab287020d5a393dc53c9441aa868681f --onto 9a17919ef11c2dba824498229633b8333a0b53d9. (2024-11-28 01:01:12)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 88e3a2b1ab287020d5a393dc53c9441aa868681f --onto 27df5e968a675780a7bcd105a19774c0c59295d8. (2024-12-01 06:28:13)

@kim-em kim-em added this pull request to the merge queue Dec 1, 2024
@kim-em kim-em removed this pull request from the merge queue due to a manual request Dec 1, 2024
@kim-em kim-em enabled auto-merge December 1, 2024 06:01
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 1, 2024 06:24 Inactive
@kim-em kim-em added this pull request to the merge queue Dec 1, 2024
Merged via the queue into master with commit 3ee2842 Dec 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants