Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: mark the Simp.Context constructor as private #6054

Merged
merged 1 commit into from
Nov 13, 2024
Merged

refactor: mark the Simp.Context constructor as private #6054

merged 1 commit into from
Nov 13, 2024

Conversation

leodemoura
Copy link
Member

motivation: this is the first step to fix the mismatch between isDefEq and the discrimination tree indexing.

@leodemoura
refactor: mark the Simp.Context constructor as private
ba3547c 
motivation: this is the first step to fix the mismatch
between `isDefEq` and the discrimination tree indexing.
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 13, 2024 02:21 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 13, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 13, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 985600f4481040bf35be3679503864f25039036f --onto 5e01e628b2ef90d8881a5ba10340032eeeabc5d4. (2024-11-13 02:31:55)
  • 💥 Mathlib branch lean-pr-testing-6054 build failed against this PR. (2024-11-13 02:37:06) View Log
  • 💥 Mathlib branch lean-pr-testing-6054 build failed against this PR. (2024-11-13 02:56:30) View Log
  • 🟡 Mathlib branch lean-pr-testing-6054 build against this PR was cancelled. (2024-11-13 03:13:07) View Log
  • 🟡 Mathlib branch lean-pr-testing-6054 build against this PR was cancelled. (2024-11-13 03:16:28) View Log
  • 💥 Mathlib branch lean-pr-testing-6054 build failed against this PR. (2024-11-13 03:41:45) View Log

kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 13, 2024
@kim-em
testing leanprover/lean4#6054
fbe4123
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Nov 13, 2024
kim-em added a commit to leanprover-community/batteries that referenced this pull request Nov 13, 2024
@kim-em
fixes for leanprover/lean4#6054
660dd9d
kim-em added a commit to leanprover-community/aesop that referenced this pull request Nov 13, 2024
@kim-em
fixes for leanprover/lean4#6054
0fa8cd2
@kim-em kim-em merged commit 1315266 into master Nov 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX is a code owner

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leodemoura @leanprover-community-bot @kim-em