feat: change Array.set to take a Nat and a tactic provided bound #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
force-pushed
the
change_array_Set
branch
from
e0c8b2d to
a1f5c3d
Compare
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 7, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 7, 2024
leanprover-community-bot
added
the
breaks-mathlib
kim-em
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 11, 2024
kim-em
added a commit
to leanprover-community/aesop
that referenced
this pull request
Nov 11, 2024
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 11, 2024
leanprover-community-bot
added
builds-mathlib
kim-em
requested review from
hargoniX,
TwoFX,
digama0 and
tydeu
as code owners
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 11, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 11, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 11, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 11, 2024
|
Why? |
|
We decided that for most users it is more ergonomic to have the autoparam tactic provide the proof, rather than requiring the anonymous constructor notation to build a Certainly it is useful sometimes to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of
Array.setto take aNat, and a tactic-provided bound, rather than aFin.Corresponding changes (but without the auto-param) for
Array.getwill arrive shortly, after which I'll go more pervasively through the Array API.