Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Coe (α → Bool) (α → Prop) and Coe (α → α → Bool) (α → α → Prop) #5088

Closed
wants to merge 1 commit into from

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Aug 19, 2024

I'm not sure if these are a terrible idea. They would be very convenient if they are not problematic...

Let's test and benchmark first and see where we stand.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 19, 2024 01:15 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 19, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Aug 19, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b486c6748b153bda628575635baa28aeeb38b8c5 --onto 53e6e99a29362bc8069330f2bf045a10c8f65912. (2024-08-19 01:22:58)
  • 💥 Mathlib branch lean-pr-testing-5088 build failed against this PR. (2024-08-19 02:20:52) View Log
  • 🟡 Mathlib branch lean-pr-testing-5088 build against this PR was cancelled. (2024-08-19 10:59:28) View Log
  • ✅ Mathlib branch lean-pr-testing-5088 has successfully built against this PR. (2024-08-19 12:05:46) View Log

@kim-em
Copy link
Collaborator Author

kim-em commented Aug 19, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 5c53692.
There were significant changes against commit 53e6e99:

  Benchmark   Metric             Change
  ===============================================
+ stdlib      fix level params    -1.3% (-14.1 σ)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 19, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 19, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 19, 2024 02:17 Inactive
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Aug 19, 2024
@kim-em kim-em removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Aug 19, 2024
@kim-em kim-em mentioned this pull request Aug 19, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 19, 2024 10:50 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 19, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 19, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 19, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 19, 2024
@kim-em
Copy link
Collaborator Author

kim-em commented Aug 19, 2024

This does seem to slow Mathlib down appreciably, unfortunately, so I'll find another way.

@kim-em kim-em closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants