Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report info trees on cmdline for .ileans #5018

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

Kha
Copy link
Member

@Kha Kha commented Aug 13, 2024

In #4976, I forgot that we do need info trees eventually on the cmdline for .ilean generation. Unfortunately, not reporting them incrementally would require an API change, so let's see what the impact of incremental reporting is

@Kha
Copy link
Member Author

Kha commented Aug 13, 2024

!bench

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 13, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 74f9dea7015467bee9010b93f7c384ede93dcf52 --onto f3e7b455bbd4ea39376e0928d0d6cb8d26bd0ba3. (2024-08-13 13:16:03)

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit bbe0ad6.
There were significant changes against commit 74f9dea:

  Benchmark                  Metric             Change
  ================================================================
+ import Lean                task-clock          -5.1%   (-19.2 σ)
+ import Lean                wall-clock          -5.1%   (-21.4 σ)
- lake config elab           instructions         2.2%    (98.7 σ)
- stdlib                     instructions         1.5%   (604.3 σ)
- stdlib                     tactic execution     3.0%    (60.9 σ)
- stdlib                     task-clock           2.2%    (38.3 σ)
+ tests/bench/ interpreted   instructions        -1.8% (-7378.0 σ)
+ tests/bench/ interpreted   task-clock         -20.8%   (-75.3 σ)
+ tests/bench/ interpreted   wall-clock         -10.1%   (-31.4 σ)

@Kha
Copy link
Member Author

Kha commented Aug 14, 2024

Merging as incrementally marking the environment as persistent is likely the way to go in any case. Further performance investigations pending.

@Kha Kha marked this pull request as ready for review August 14, 2024 08:59
@Kha Kha added this pull request to the merge queue Aug 14, 2024
Merged via the queue into leanprover:master with commit 337db03 Aug 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants