Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: output panics into Lean's redirected stderr #4952

Merged
merged 2 commits into from
Aug 12, 2024
Merged

feat: output panics into Lean's redirected stderr #4952

merged 2 commits into from
Aug 12, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Aug 8, 2024

...unless we are about to kill the process anyway (which is not the default)

Ensures panics are visible as regular messages in the language server and properly ordered in relation to other messages on the cmdline

@Kha Kha enabled auto-merge August 8, 2024 07:48
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 8, 2024
@Kha Kha added this pull request to the merge queue Aug 12, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 240ebff549a2cf557f9abe9568f5de885f13e50d --onto 5f31e938c1bf5bb2d6d2d29b26ea932ade115357. (2024-08-12 12:16:17)

Merged via the queue into leanprover:master with commit dd4e26f Aug 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kha @leanprover-community-mathlib4-bot