-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: name variables in Data/BitVec consistently #4930
chore: name variables in Data/BitVec consistently #4930
Conversation
This is purely a naming change to make our bitvector proofs more consistent.
Mathlib CI status (docs):
|
Co-authored-by: AnotherAlexHere <[email protected]>
I think it may be helpful to explain the purpose of these changes and give examples. |
I updated the commit message accordingly. |
Thanks! Happy to merge when you mark it as ready. |
Co-authored-by: AnotherAlexHere <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This change canonicalizes the BitVec variable names to
x y z : BitVec
instead of alternative namings such ass t : BitVec
ora b : BitVec
. Variable names that carry semantic meaning such as(msbs : BitVec w) (lsb : Bool)
remain untouched.This is purely a naming change to make our bitvector proofs more consistent and polish the (auto-generated) documentation as a very small step towards polishing the documentation of the BitVec library in Lean.