Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: split libleanshared on Windows to avoid symbol limit #4860

Merged
merged 4 commits into from
Aug 12, 2024
Merged

fix: split libleanshared on Windows to avoid symbol limit #4860

merged 4 commits into from
Aug 12, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Jul 29, 2024

No description provided.

@Kha Kha added the release-ci Enable all CI checks for a PR, like is done for releases label Jul 29, 2024
@Kha Kha requested a review from leodemoura as a code owner August 2, 2024 09:27
@Kha Kha requested a review from tydeu as a code owner August 2, 2024 11:58
@Kha Kha force-pushed the split-leanshared branch 6 times, most recently from 4374dc9 to 9384e19 Compare August 9, 2024 09:47
@Kha Kha requested a review from kim-em as a code owner August 9, 2024 09:47
@Kha Kha enabled auto-merge August 9, 2024 09:47
@Kha Kha disabled auto-merge August 9, 2024 11:44
@Kha Kha force-pushed the split-leanshared branch from cf0aa6e to 5cc9eb9 Compare August 9, 2024 16:13
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 9, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 238885436b89b0b58caa2f5430a7a5fefffc4003 --onto dd6ed124baef64a26ef5860f49597fdcef371239. (2024-08-09 22:00:36)

@Kha Kha force-pushed the split-leanshared branch from 3923fe3 to d0a62e9 Compare August 12, 2024 12:13
@Kha Kha merged commit c5114c9 into leanprover:master Aug 12, 2024
18 checks passed
@Kha Kha deleted the split-leanshared branch August 12, 2024 12:14
@Kha Kha restored the split-leanshared branch September 27, 2024 14:54
@Kha Kha deleted the split-leanshared branch September 27, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kha @leanprover-community-mathlib4-bot