-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: usize for array types #4801
Conversation
Mathlib CI status (docs):
|
Add efficient usize functions for Array, ByteArray, FloatArray. Closes leanprover#4654
f42a424
to
75c853e
Compare
It was necessary to update stage0 in order to use the |
awaiting-review |
I didn't expect this to need a stage0 update. Why is that so? |
I didn't expect that either. It's because these are |
Hmm, still somewhat strange, the the C symbol should already be there, shouldn’t it? Did you try setting But I’m no expert here. I’m just bringing this up because PRs with stage0 updates need to be manually merged by (I think) Sebastian or Leo. If you’d split it in two PRs then more people can merge and it can go through the normal merge queue. |
I'm not an expert there either. If I don't update stage0 then calls to Yes, I read the manual. I also made sure the commits were clean. I was thinking about splitting in two but I was hoping Sebastian would say something before I did that. Either way, there needs to be a stage0 update between the two commits. |
Right, this works of course! It’s just that with two PRs, the stage0 update can happen via the github bot. But not problem for me letting Sebastian merge this PR :-) |
There's a bot for that! I thought Sebastian would have to do it either way... I will split right away then! |
There is a bot these days. It runs automatically after a PR merge whenever it touches So you could even leave a comment in
and it’ll happen automatically after the PR enters master (and it will nicely override this comment). |
Thank you so much for your help Joachim! This PR would have stayed in limbo for a long time without your enlightening comments! |
Add efficient
usize
functions forArray
,ByteArray
,FloatArray
.This is part 1 of 2 since there is a need to update stage0 between the two parts. (See discussion below.)
Closes #4654