Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: ensure Expr.replaceExpr preserve DAG structure in Exprs #4779

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

leodemoura
Copy link
Member

No description provided.

@leodemoura
Copy link
Member Author

!bench

@leodemoura leodemoura enabled auto-merge July 18, 2024 02:10
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 18, 2024 02:18 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jul 18, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 18, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 4eb842560ce2c8f3b99a2f2867e87585e9159ecf --onto ba3565f441a4533490c339ead6d9ee5b1220110b. (2024-07-18 02:26:35)

Merged via the queue into master with commit a94805f Jul 18, 2024
13 checks passed
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit d198a7a.
There were significant changes against commit 4eb8425:

  Benchmark     Metric                  Change
  ========================================================
+ reduceMatch   instructions             -5.3% (-1829.0 σ)
+ stdlib        attribute application    -2.6%   (-30.5 σ)
+ stdlib        fix level params         -2.5%   (-38.5 σ)
+ stdlib        tactic execution         -1.5%  (-151.3 σ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants