-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generalized Parsec
#4774
feat: generalized Parsec
#4774
Conversation
Mathlib CI status (docs):
|
By switching around the namespaces and naming you have practically guaranteed to break every single downstream user of |
Looking around the Lean Zulip there is 1 thread about parsec every couple of months, so I would hope the user base is currently rather small. I know that doc-gen's dependency closure does do a bit with Parsec and LeanSAT of course as well, apart from that I'm not aware of projects that do use Parsec. My main motivation for organising the namespaces as they are was mostly the original Haskell As for the error messages you would basically end up with:
as well as of course a couple of missing identifiers that moved to the
These are obviously not as helpful as they could be. I would hope that with a little explanation in the release notes we could help migrate the few users that do exist? Alternatively we can turn |
eb1caa9
to
8a886c3
Compare
8a886c3
to
9e4a073
Compare
9e4a073
to
8d6e0dc
Compare
8d6e0dc
to
d7fac39
Compare
For experimentation by @the-sofi-uwu.
I also have an efficient number parser in LeanSAT that I am planning to upstream after we have sufficiently bikeshed this change.