feat: test minimizing slowdown from #4595 #4755
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimization of a fairly typical slowdown from #4595 in Mathlib. The bad slowdowns seem to mostly be in declarations that generate many different
simp
proofs internally (often viaaesop
).This test works fine on
master
, but is very slow on #4595. There's some nonlinearity going on here: the time savings coming from replacing eachsimp only
bysorry
adds up to more than the total time.