Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test minimizing slowdown from #4595 #4755

Closed
wants to merge 2 commits into from
Closed

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Jul 16, 2024

This is a minimization of a fairly typical slowdown from #4595 in Mathlib. The bad slowdowns seem to mostly be in declarations that generate many different simp proofs internally (often via aesop).

This test works fine on master, but is very slow on #4595. There's some nonlinearity going on here: the time savings coming from replacing each simp only by sorry adds up to more than the total time.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 16, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jul 16, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 31de2494fb603081d261a5ded574b7c2f884c755 --onto ce73bbe277140201cdb3ad3015c13d01948704b2. (2024-07-16 03:19:03)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 1a9cbc96f1cbbbd2bb0092e574c5de64dc9d948c --onto ce73bbe277140201cdb3ad3015c13d01948704b2. (2024-07-16 13:47:18)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 16, 2024 13:38 Inactive
@kim-em
Copy link
Collaborator Author

kim-em commented Nov 29, 2024

I've moved this directly into #4595. (I'm not entirely sure why I didn't do that in the first place.)

@kim-em kim-em closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants