Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: IndGroupInfo and IndGroupInst #4738

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Jul 13, 2024

This adds the types

  • IndGroupInfo, a variant of InductiveVal with information that
    applies to a whole group of mutual inductives and
  • IndGroupInst which extends IndGroupInfo with levels and parameters
    to indicate a instantiation of the group.

One purpose of this abstraction is to make it clear when a fuction
operates on a group as a whole, rather than a specific inductive within
the group.

This is extracted from #4718 and #4733 to reduce PR size and improve
bisectability.

This adds the types
* `IndGroupInfo`, a variant of `InductiveVal` with information that
   applies to a whole group of mutual inductives and
* `IndGroupInst` which extends `IndGroupInfo` with levels and parameters
   to indicate a instantiation of the group.

One purpose of this abstraction is to make it clear when a fuction
operates on a group as a whole, rather than a specific inductive within
the group.

This is extracted from #4718 and #4733 to reduce PR size and improve
bisectability.
@nomeata nomeata requested a review from leodemoura as a code owner July 13, 2024 07:45
@nomeata nomeata added the will-merge-soon …unless someone speaks up label Jul 13, 2024
@nomeata nomeata requested a review from kim-em as a code owner July 13, 2024 07:45
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 13, 2024 07:54 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 13, 2024 08:03 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 13, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a6ae49c3abaade6f2f4420665b4a67d93069fd81 --onto 5f70c1ca64a2c05a5866c47b9eb80a92034433ec. (2024-07-13 08:10:44)

@nomeata nomeata added this pull request to the merge queue Jul 13, 2024
Merged via the queue into master with commit 1118978 Jul 13, 2024
13 checks passed
@nomeata nomeata deleted the joachim/indgroupinfo branch July 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants