Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename HashMap.remove to HashMap.erase #4725

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Jul 11, 2024

The name remove was chosen because it is more popular in mainstream programming languages, but being consistent with other Lean container types (including Lean.HashMap and Batteries.HashMap) is more important, so let's change the name while we still can.

@TwoFX TwoFX requested a review from kim-em July 11, 2024 06:10
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 11, 2024 06:15 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 11, 2024
@TwoFX TwoFX added this pull request to the merge queue Jul 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 16, 2024
@TwoFX TwoFX enabled auto-merge July 16, 2024 07:16
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jul 16, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 31de2494fb603081d261a5ded574b7c2f884c755 --onto ce73bbe277140201cdb3ad3015c13d01948704b2. (2024-07-16 07:32:42)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 7aec6c9ae7a54935ada0df0b4cc1efafc2291007 --onto ce73bbe277140201cdb3ad3015c13d01948704b2. (2024-07-16 08:14:26)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 16, 2024 08:07 Inactive
@TwoFX TwoFX added this pull request to the merge queue Jul 16, 2024
Merged via the queue into master with commit 1a9cbc9 Jul 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants