Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make iff theorem generated by @[ext] preserve inst implicits #4710

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: make iff theorem generated by @[ext] preserve inst implicits #4710

merged 1 commit into from
Jul 10, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Jul 10, 2024

Previously all arguments from the ext theorem were made implicit, but now only default and strict implicits are made implicit.

@kmill
fix: make iff theorem generated by @[ext] preserve inst implicits
4f5e741 
Previously all arguments from the ext theorem were made implicit, but now only default and strict implicits are made implicit.
@kmill kmill requested a review from digama0 as a code owner July 10, 2024 00:49
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 10, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jul 10, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4710
9a9acb5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 10, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4710
35278e7
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases labels Jul 10, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jul 10, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jul 10, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4710
95abfbb
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 10, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4710
adeb7fe
@kmill kmill added this pull request to the merge queue Jul 10, 2024
Merged via the queue into leanprover:master with commit 3c18d15 Jul 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees
No one assigned
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmill @leanprover-community-mathlib4-bot