feat: Std.HashMap #4583
Merged
feat: Std.HashMap #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
reviewed
Jun 30, 2024
kim-em
reviewed
Jun 30, 2024
kim-em
reviewed
Jun 30, 2024
kim-em
reviewed
Jun 30, 2024
kim-em
reviewed
Jun 30, 2024
kim-em
reviewed
Jun 30, 2024
kim-em
reviewed
Jun 30, 2024
|
Some functions don't have any theorems (e.g. |
This was referenced Jul 1, 2024
Merged
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
Split from #4583
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
Split from #4583 Mathlib has `isSome_map'` but calls it `isSome_map`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
Split from #4583 `exists_of_set` appears in Batteries as `exists_of_set'`. The `exists_of_set` version is unused in batteries and mathlib at least and I would argue that the primed version (i.e., the one added in this PR) is always better anyway. `isEmpty_iff` appears in mathlib as `isEmpty_iff_eq_nil`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
Split from #4583 Rewriting the `i` in `xs[i]` usually fails with `motive is not type correct`, but with this lemma it works.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
Split from #4583
This was referenced Jul 2, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
Split from #4583
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
Split from #4583
|
@david-christiansen Thank you very much for the detailed review! I'll give you a chance to confirm that all of your comments have been addressed and then I think it's time to get this merged. |
david-christiansen
approved these changes
Jul 5, 2024
|
This is great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary PRs:
Quick overview over API/naming changes compared to
Lean.HashMapandBatteries.HashMap:Lean
find?->get?/getElem?find!->get!/getElem!findD->getDfindEntry?-> not implemented for nowinsert'->containsThenInsert(order reversed in result)insertIfNew->getThenInsertIfNew?(order reversed in result)numBuckets->Internal.numBucketsofListWith-> not implemented for nowArray.groupByKey-> not implemented for nowmerge-> not implemented for now, but you can useinsertManyBatteries
modify-> not implemented for nowmergeWith-> not implemented for nowmergeWithM-> not implemented for now