Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option debug.byAsSorry true #4576

Merged
merged 2 commits into from
Jun 27, 2024
Merged

feat: add option debug.byAsSorry true #4576

merged 2 commits into from
Jun 27, 2024

Conversation

leodemoura
Copy link
Member

No description provided.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 27, 2024 17:41 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 27, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 294f7fbec5126ec99117a775bf9408ee94d9b8c2 --onto 62b6e5878981d1bb6d414f21b0c6f8d8a36e6834. (2024-06-27 17:53:59)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 27, 2024 18:01 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit 30a922a Jun 27, 2024
13 checks passed
@kim-em kim-em mentioned this pull request Jul 22, 2024
Closed
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jul 22, 2024
@kim-em
chore: robustifying for debug.byAsSorry (#14993)
93c07b2 
These are some minor changes, which are think are positive or neutral in any case, that help Mathlib compile under `set_option debug.byAsSorry true` (an option that [arrived](leanprover/lean4#4576) in v4.10 that turns all `by` blocks into sorries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomeata nomeata nomeata left review comments

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leodemoura @leanprover-community-mathlib4-bot @nomeata