Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lake: computation of precompiled libs #4566

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: lake: computation of precompiled libs #4566

merged 1 commit into from
Jun 27, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Jun 26, 2024

Addresses a few issues with precompile library computation.

  • Fixes a bug where Lake would always precompile the package of a module.
  • If a module is precompiled, it now precompiles its imports. Previously, it would only do this if imported.

Closes #4565.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 26, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4566
4421b93
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 26, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4566
1cc7144
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 26, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jun 26, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ✅ Mathlib branch lean-pr-testing-4566 has successfully built against this PR. (2024-06-26 03:01:27) View Log
  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-06-26 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-06-26 17:16:51)

@tydeu tydeu force-pushed the lake/fix-precompile-libs branch from a051669 to 990d355 Compare June 26, 2024 17:03
@tydeu tydeu added will-merge-soon …unless someone speaks up release-ci Enable all CI checks for a PR, like is done for releases labels Jun 26, 2024
@tydeu tydeu marked this pull request as ready for review June 26, 2024 18:57
@tydeu tydeu added this pull request to the merge queue Jun 27, 2024
Merged via the queue into leanprover:master with commit 294f7fb Jun 27, 2024
25 checks passed
@tydeu tydeu deleted the lake/fix-precompile-libs branch June 27, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extern_lib targets from dependencies aren't loaded when compiling lean files
2 participants
@tydeu @leanprover-community-mathlib4-bot