Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IndPredBelow should not add auxiliary declarations containing sorry #4563

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

leodemoura
Copy link
Member

Issue #4535 is being affected by a bug in the structural inductive predicate termination checker (IndPred.lean). This module did not exist in Lean 3, and it is buggy in Lean 4. In the given example, it introduces an auxiliary declaration containing a sorry, and the fails. This PR ensures this kind of declaration is not added to the environment.

Closes #4535

TODO: we need a new maintainer for the IndPred.lean.

…`sorry`

Issue #4535 is being affected by a bug in the structural inductive
predicate termination checker (`IndPred.lean`). This module did not
exist in Lean 3, and it is buggy in Lean 4. In the given example,
it introduces an auxiliary declaration containing a `sorry`, and the
fails. This PR ensures this kind of declaration is not added to the
environment.

Closes #4535

TODO: we need a new maintainer for the `IndPred.lean`.
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 25, 2024 20:47 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 25, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 230f33570256016e658abe48cca9a08e411d9f4b --onto 49249b91074a8eab8926308cedc2b3e31d973b51. (2024-06-25 20:57:23)

@leodemoura leodemoura added this pull request to the merge queue Jun 25, 2024
Merged via the queue into master with commit fb6d29e Jun 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

declaration is incorrectly marked as using sorry
2 participants