Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose flags for the bundled C compiler #4477

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Jun 17, 2024

Expose the C compiler and linker flags used with the bundled compiler (clang) to Lean code. This is needed to skip the use of leanc in Lake.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 17, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-06-14 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-06-17 16:00:53)

@tydeu tydeu added the release-ci Enable all CI checks for a PR, like is done for releases label Jun 17, 2024
@tydeu tydeu marked this pull request as ready for review June 17, 2024 21:17
@tydeu tydeu requested a review from leodemoura as a code owner June 17, 2024 21:17
@tydeu tydeu marked this pull request as draft June 17, 2024 21:18
@tydeu tydeu marked this pull request as ready for review June 17, 2024 23:33
@tydeu tydeu requested a review from Kha June 17, 2024 23:34
@tydeu
Copy link
Member Author

tydeu commented Jun 17, 2024

@Kha This is the first part of what we discussed regarding removing the leanc dependency from Lake.

@tydeu tydeu added this pull request to the merge queue Jun 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2024
@tydeu tydeu added this pull request to the merge queue Jun 22, 2024
Merged via the queue into leanprover:master with commit 0d529e1 Jun 22, 2024
23 checks passed
@tydeu tydeu deleted the expose-internal-flags branch June 22, 2024 02:24
paulcadman added a commit to funexists/raylean that referenced this pull request Aug 18, 2024
The LEAN_CC variable was introduced recently to use override the bundled
clang (leanc) from the lean toolchain.

leanprover/lean4#4477 (comment)

We must use LEAN_CC on linux because the example executable will fail to
link if raylib is built with a glibc that's incompatible with the version
that's bundled with leanc. This currently happens with the arch distro.
paulcadman added a commit to funexists/raylean that referenced this pull request Aug 18, 2024
The LEAN_CC variable was introduced recently to use override the bundled
clang (leanc) from the lean toolchain.

leanprover/lean4#4477 (comment)

We must use LEAN_CC on linux because the example executable will fail to
link if raylib is built with a glibc that's incompatible with the version
that's bundled with leanc. This currently happens with the arch distro.

Thanks to @keeganperry7 for figuring this out.

Co-authored-by: keeganperry7 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants