Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: documenting Char and upstreaming extensionality from batteries #4438

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

jtristan
Copy link
Contributor

  • Basic documentation for characters
  • Upstreamed two extensionality theorems from batteries

@jtristan jtristan requested a review from kim-em as a code owner June 12, 2024 18:43
@jtristan jtristan changed the title doc, chore: documenting Char and upstreaming extensionality from batteries doc: documenting Char and upstreaming extensionality from batteries Jun 12, 2024
doc/char.md Outdated Show resolved Hide resolved
@kim-em
Copy link
Collaborator

kim-em commented Jun 13, 2024

The CI failure is not your fault: unfortunately this PR landed while we were in the middle of switching over our CI machine provider. I think that rebasing on master should result in CI re-running successfully.

@kim-em kim-em added the awaiting-author Waiting for PR author to address issues label Jun 13, 2024
jtristan and others added 2 commits June 13, 2024 11:31
Co-authored-by: Kim Morrison <[email protected]>
@jtristan jtristan requested a review from kim-em June 13, 2024 15:48
@kim-em kim-em added this pull request to the merge queue Jun 16, 2024
Merged via the queue into leanprover:master with commit f237fb6 Jun 16, 2024
11 checks passed
@jtristan jtristan deleted the jtristan-Char-lemmas branch June 16, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author Waiting for PR author to address issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants