Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ppOrigin to use MessageData.ofConst #4362

Merged
merged 2 commits into from
Jun 5, 2024
Merged

feat: ppOrigin to use MessageData.ofConst #4362

merged 2 commits into from
Jun 5, 2024

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Jun 5, 2024 •
edited
Loading

so that the pretty-printed origin is clickable, and avoid the unnecessary @.

Particularly nice is this fix:

 /--
-info: [Meta.Tactic.simp.discharge] @bar discharge ✅
+info: [Meta.Tactic.simp.discharge] bar discharge ✅
       autoParam T _auto✝
-  [Meta.Tactic.simp.rewrite] { }:1000, T ==> True
-[Meta.Tactic.simp.rewrite] @bar:1000, U ==> True
+  [Meta.Tactic.simp.rewrite] T.mk:1000, T ==> True
+[Meta.Tactic.simp.rewrite] bar:1000, U ==> True
 -/

@nomeata
feat: ppOrigin to use MessageData.ofConst
9ca8687 
so that the pretty-printed origin is clickable
@nomeata nomeata requested a review from leodemoura as a code owner June 5, 2024 08:15
@nomeata nomeata added the will-merge-soon …unless someone speaks up label Jun 5, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 5, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 5, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4362
02ac003
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 5, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4362
fc4b4f2
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 5, 2024 09:35 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 5, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4362
72f7f53
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 5, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4362
0dc4f67
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 5, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

@nomeata nomeata added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit e33c32f Jun 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nomeata @leanprover-community-mathlib4-bot