Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upstream lemmas about basic List/Array operations #4059

Merged
merged 5 commits into from
May 6, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented May 3, 2024

This PR upstreams lemmas about List/Array operations already defined in Lean from std/batteries.

Happy to take suggestions about increasing or decreasing scope.

@kim-em kim-em added the awaiting-review Waiting for someone to review the PR label May 3, 2024
@kim-em kim-em requested a review from digama0 as a code owner May 3, 2024 04:00
@digama0
Copy link
Collaborator

digama0 commented May 3, 2024

For this and future moves, would it be possible to follow the same protocol we used during the port, and have the initial commit be a plain copy/paste job so that the diffs needed to make it compile (and any additional changes) stand out more clearly?

@kim-em
Copy link
Collaborator Author

kim-em commented May 3, 2024

For this and future moves, would it be possible to follow the same protocol we used during the port, and have the initial commit be a plain copy/paste job so that the diffs needed to make it compile (and any additional changes) stand out more clearly?

Ah, yes, sorry, I know you've asked this before. I'll try to remember. It's a bit difficult to know where exactly to make that commit here: I initially copy-pasted in the entire files that I was drawing from, and then whittled down as dependencies weren't available or I decided I didn't want something upstreamed.

@digama0
Copy link
Collaborator

digama0 commented May 3, 2024

As long as the diff isn't a complete mess, I think it's okay if the first commit includes the entirety of the affected files and hence subsequent commits contain a lot of red

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 3, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented May 3, 2024

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e733149134a9fa9e92bc589afbe6c2cbb665835c --onto b470eb522bfd68ca96938c23f6a1bce79da8a99f. (2024-05-03 04:25:49)
  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e733149134a9fa9e92bc589afbe6c2cbb665835c --onto 00cf5771f31e7de7f6ab3089cb4b9ffa606a35ed. (2024-05-06 03:54:35)

@kim-em kim-em enabled auto-merge May 6, 2024 03:36
@kim-em kim-em added will-merge-soon …unless someone speaks up and removed awaiting-review Waiting for someone to review the PR labels May 6, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc May 6, 2024 03:50 Inactive
@kim-em kim-em added this pull request to the merge queue May 6, 2024
Merged via the queue into master with commit 3c11cca May 6, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants