-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upstream lemmas about basic List/Array operations #4059
Conversation
Co-authored-by: Mario Carneiro <[email protected]>
For this and future moves, would it be possible to follow the same protocol we used during the port, and have the initial commit be a plain copy/paste job so that the diffs needed to make it compile (and any additional changes) stand out more clearly? |
Ah, yes, sorry, I know you've asked this before. I'll try to remember. It's a bit difficult to know where exactly to make that commit here: I initially copy-pasted in the entire files that I was drawing from, and then whittled down as dependencies weren't available or I decided I didn't want something upstreamed. |
As long as the diff isn't a complete mess, I think it's okay if the first commit includes the entirety of the affected files and hence subsequent commits contain a lot of red |
Mathlib CI status (docs):
|
This PR upstreams lemmas about List/Array operations already defined in Lean from std/batteries.
Happy to take suggestions about increasing or decreasing scope.