Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove Subtype.instInhabited #4055

Merged
merged 2 commits into from
May 6, 2024
Merged

fix: remove Subtype.instInhabited #4055

merged 2 commits into from
May 6, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented May 2, 2024 •
edited
Loading

It has had a long history going back 10 years, but its time has come to an end since this instance is never applicable.

@kmill kmill marked this pull request as draft May 2, 2024 20:24
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 2, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 2, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4055
dc7891f
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 2, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4055
9ac5da4
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label May 2, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented May 2, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❌ Mathlib branch lean-pr-testing-4055 built against this PR, but linting failed. (2024-05-02 20:55:37) View Log
  • 🟡 Mathlib branch lean-pr-testing-4055 build against this PR was cancelled. (2024-05-02 21:13:13) View Log
  • ❌ Mathlib branch lean-pr-testing-4055 built against this PR, but lean4checker failed. (2024-05-02 22:13:18) View Log
  • 🟡 Mathlib branch lean-pr-testing-4055 build this PR didn't complete normally. (2024-05-02 22:40:06) View Log
  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-05-02 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-05-03 02:07:24)
  • 💥 Mathlib branch lean-pr-testing-4055 build failed against this PR. (2024-05-03 02:08:03) View Log
  • 💥 Mathlib branch lean-pr-testing-4055 build failed against this PR. (2024-05-03 11:02:47) View Log
  • ✅ Mathlib branch lean-pr-testing-4055 has successfully built against this PR. (2024-05-03 13:04:03) View Log
  • ✅ Mathlib branch lean-pr-testing-4055 has successfully built against this PR. (2024-05-03 13:47:56) View Log

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 2, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4055
6bb3a52
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 2, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4055
e8ecfe6
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 2, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4055
df5ecc0
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 2, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4055
cba9d8b
kmill pushed a commit to leanprover-community/batteries that referenced this pull request May 3, 2024
@leanprover-community-mathlib4-bot @kmill
Update lean-toolchain for testing leanprover/lean4#4055
a87faad
kmill pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 3, 2024
@leanprover-community-mathlib4-bot @kmill
Update lean-toolchain for testing leanprover/lean4#4055
3c6bf37
@kmill
fix: remove Subtype.instInhabited
a572b56 
It has a long history going back [10 years](leanprover-community/lean@3afad10#diff-4e22e2bb74f004d2ff7cdabcb5c01429abbc906e20befe2517679e257b4387e4R41), this instance cannot fire with the current system.
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 3, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4055
99fc7d8
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 3, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4055
36d83d3
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels May 3, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 3, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4055
ea6a83e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 3, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4055
cc4a197
@kmill
Copy link
Collaborator Author

kmill commented May 3, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 24b4725.
There were no significant changes against commit b470eb5.

@kmill kmill marked this pull request as ready for review May 6, 2024 10:59
@kim-em kim-em added this pull request to the merge queue May 6, 2024
Merged via the queue into leanprover:master with commit 9e4c414 May 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmill @leanprover-community-mathlib4-bot @leanprover-bot @kim-em