Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add set_option diag true for diagnostic counters #4016

Merged
merged 2 commits into from
Apr 28, 2024
Merged

feat: add set_option diag true for diagnostic counters #4016

merged 2 commits into from
Apr 28, 2024

Conversation

leodemoura
Copy link
Member

It currently only reports how many times each declaration has been unfolded, and how often the isDefEq heuristic for f a =?= f b has been used. Only counters above the threshold are reported.

@leodemoura
feat: add option set_option diag true
0980998 
It currently only reports how many times each declaration has been
unfolded, and how often the `isDefEq` heuristic for `f a =?= f b` has
been used. Only counters above the threshold are reported.
@leodemoura leodemoura requested review from kim-em and tydeu as code owners April 28, 2024 21:46
@leodemoura leodemoura enabled auto-merge April 28, 2024 21:46
@leodemoura leodemoura disabled auto-merge April 28, 2024 21:57
@leodemoura leodemoura enabled auto-merge April 28, 2024 21:57
@leodemoura leodemoura changed the title feat: add option set_option diag true feat: add set_option diag true for diagnostic counters Apr 28, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 28, 2024 22:13 Inactive
@leodemoura leodemoura added this pull request to the merge queue Apr 28, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 28, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase adc4c6a7cf27f6440a1fe9293dcf851f2a4ddc9b --onto 1630d9b803164bb522f4a40fbc8fbf104cca425e. (2024-04-28 22:15:30)

Merged via the queue into master with commit 9d14c04 Apr 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-mathlib4-bot