-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not lift (<- ...)
over pure if-then-else
#3820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remark: some of them were harmless since they were accessing some read-only state.
Mathlib CI status (docs):
|
Thank you Leo! I got hit by this again recently so I am very happy to see it fixed |
1 task
eric-wieser
reviewed
Apr 2, 2024
Comment on lines
-31
to
+32
by subst h; exact $(← mkSameCtorRhs todo):term | ||
by subst h; exact $sameCtor:term |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eric-wieser
added a commit
to leanprover-community/quote4
that referenced
this pull request
Apr 2, 2024
Once it lands in a release, the change in leanprover/lean4#3820 to detect accidental do lifting misfires on quotations. To avoid breakage later, we manually lift out this expression.
kim-em
pushed a commit
to leanprover-community/quote4
that referenced
this pull request
Apr 2, 2024
Once it lands in a release, the change in leanprover/lean4#3820 to detect accidental do lifting misfires on quotations. To avoid breakage later, we manually lift out this expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, only
(<- ...)
s occurring in the condition of a pure if-then-else are lifted.That is,
if (<- foo) then ... else ...
is ok, butif ... then (<- foo) else ...
is not. See #3713closes #3713
This PR also adjusts this repo. Note that some of the
(<- ...)
were harmless since they were just accessing someread-only state.