feat: hovering over binders shows their types #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies `withBindingBodyUnusedName` to annotate the syntax for the variable with its corresponding fvar. Now, for example, you can hover over the variables in `fun x y => ...` in the infoview to see their types. Also adds such annotations for the variables in `let` and `let_fun`. Implementation note: since the fvar is local to `withBindingBody'`, this uses a fresh position for the fvar using `nextExtraPos`. This makes it safe to use `withBindingBody'` for the same expression repeatedly, since each generated fvar gets its own position.
github-actions
bot
added
the
toolchain-available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
withBindingBodyUnusedNameto annotate the syntax for the variable with its corresponding fvar. Now, for example, you can hover over the variables infun x y => ...in the infoview to see their types. This change affects notations such as∃ n, n = 1, where hovering overnshows thatn : Nat.Also adds such annotations for the variables in
letandlet_fun.Implementation note: the variables are annotated with fresh positions using
nextExtraPos.Removes the unused and unnecessary
Lean.PrettyPrinter.Delaborator.liftMetaM.Closes #1618, closes #2737