Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lemma selection improvements to to rw? and lazy discriminator tree #3769

Merged
merged 6 commits into from
Mar 27, 2024

Conversation

joehendrix
Copy link
Contributor

@joehendrix joehendrix commented Mar 26, 2024

This makes several changes to rw? and lazy discrimination trees based on test failures in rewrite search.

Changes include:

  1. Reverting to Mathlib function for candidate lemma priority in rw?
  2. Introducing additional filters for auto-generated named in lazy discriminator tree.
  3. Refactoring lazy discriminator values to clarify what is stored.
  4. Including star keys in calculation of match closeness in prioritization.
  5. Using more fields in current core context when initializing lazy discriminator tree and avoiding max heartbeat issues.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 26, 2024 07:59 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 26, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Mar 26, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Mar 26, 2024

Mathlib CI status (docs):

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 26, 2024 09:25 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 26, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 26, 2024 17:23 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 26, 2024
@joehendrix joehendrix changed the title fix: adjust lemma blacklist and rewrite priorities in rw? fix: lemma selection improvements to to rw? and lazy discriminator tree Mar 26, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 26, 2024 20:46 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 26, 2024
@joehendrix joehendrix added this pull request to the merge queue Mar 26, 2024
Merged via the queue into master with commit b17c47d Mar 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants