fix: toUInt64LE! and toUInt64BE! are swapped #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
|
@Vtec234, just checking if you wanted to look at this? I'm happy with this. |
|
CI had failed, but I think just transiently. |
|
Nope, not transient. Let me merge master and see if that helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3657
These functions are mostly not used by lean itself, but it does affect two occurrences of
ByteArray.toUInt64LE! <$> IO.getRandomBytes 8which I left as is instead of switching them to usetoUInt64BE!to preserve behavior; but they are random bytes anyway seeded by the OS so it's unlikely any use of them depending on particular values was sound to begin with.