chore: CI: add actionlint action, fix actions #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I keep messing things up, so time for some guard rails.
nomeata
changed the title
github-actions
bot
added
the
toolchain-available
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
@nomeata, this came back from the merge queue due to a conflict. I'm happy with this if you want to send it back once the conflict is resolved. |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 15, 2024
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep messing things up, so time for some guard rails, so check them using
actionlint.
This also runs shellcheck on the files. Shellcheck
is a bit picky about putting double quotes around variables, and will flag many
cases where we know it’s safe, but why not simply always write the safer variant.
Unfortunately, actionlint does not (yet) check
actions/github-scriptscripts, which isunfortunate. Maybe they will in the future (rhysd/actionlint#389)