Tag names #2629
Merged
Tag names #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a misspelled/mistyped word in a comment.
david-christiansen
added
the
missing RFC
david-christiansen
force-pushed
the
tag-names
branch
from
039f858 to
3ed933a
Compare
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 5, 2023
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
Kha
approved these changes
Oct 6, 2023
Before, Lean would simply emit the message "tag not found". With this change, it also tells the user what they could have written that would be accepted.
david-christiansen
force-pushed
the
tag-names
branch
from
3ed933a to
cef4434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put an X in this bracket to confirm you have read the
External Contribution Guidelines.
Please put the link to your
RFCorbugissue here.PRs missing this link will be marked as
missing RFC.If that issue does not already have approval from a developer,
please be sure to open this PR in "Draft" mode.
Please make sure the PR has excellent documentation and tests.
If we label it
missing documentationormissing teststhen it needs fixing!You can manage the
awaiting-review,awaiting-author, andWIPlabelsyourself, by writing a comment containing one of these labels on its own line.
Right now, Lean's error message when providing a nonexistent case tag is somewhat unhelpful. It says
tag not found.With these changes, Lean instead lists the available tags that the user could have written, making the message more helpful. I also think that this phrasing is somewhat more likely to inform a new user that a "tag" is the name of the case that comes out of
casesorinduction.