Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hygieneInfo parser (aka this 2.0) #2246

Closed
wants to merge 1 commit into from
Closed

feat: hygieneInfo parser (aka this 2.0) #2246

wants to merge 1 commit into from

Conversation

digama0
Copy link
Collaborator

@digama0 digama0 commented May 30, 2023 •
edited
Loading

As discussed on Zulip, this implements a hygieneInfo parser, which captures the hygiene information like ident, but without actually parsing anything. This can be used to implement call-site hygienic identifiers like have this := .... The reimplementation of have this on top of this parser is done in #2247.

Kha
Kha approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@Kha Kha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for #2245 to be merged/resolved first

@Kha
Copy link
Member

Kha commented May 30, 2023

After thinking a bit more about this change, I'm undecided on the name macroScope. It makes sense in that it represents the "scope of a macro" but of course we already have a term of that name, with macroScope encoding a list of macro scopes.

@digama0
Copy link
Collaborator Author

digama0 commented May 30, 2023

I had the same thought, perhaps hygiene is better?

@Kha
Copy link
Member

Kha commented May 30, 2023

Yeah, maybe hygieneInfo? Then it could be mkIdentWithHygieneInfo

@digama0 digama0 mentioned this pull request May 30, 2023
Merged
@digama0 digama0 changed the title feat: macroScope parser (aka this 2.0) feat: hygieneInfo parser (aka this 2.0) May 30, 2023
@Kha
Copy link
Member

Kha commented Jun 2, 2023

Merged as part of #2247

@Kha Kha closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kha Kha Kha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@digama0 @Kha