Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail_if_success fails despite no success #1375

Closed
Tracked by #357
Vtec234 opened this issue Jul 27, 2022 · 0 comments
Closed
Tracked by #357

fail_if_success fails despite no success #1375

Vtec234 opened this issue Jul 27, 2022 · 0 comments

Comments

@Vtec234
Copy link
Member

Vtec234 commented Jul 27, 2022

Description

example : True := by
  /- tactic 'assumption' failed
  ⊢ False -/
  /- tactic succeeded -/
  fail_if_success (have : False := by assumption)
  trivial

example : True := by
  have : False := by
    fail_if_success assumption
    sorry
  trivial

Steps to Reproduce

Expected behavior: The first variant should succeed (since the have fails).

Actual behavior: It reports that the tactic succeeded.

Reproduces how often: 100%

Versions

nightly-2022-07-27 and 00dd9da

Additional Information

I apologize for the title :)
@Vtec234 Vtec234 mentioned this issue Jul 27, 2022
Closed
1 task
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this issue Jul 31, 2022
@Vtec234 @digama0
chore: update to nightly-2022-07-28 (#357)
f6714df 
Changed all names related to leanprover/lean4#1346 that I could find.

- [x] leanprover/lean4#1375

Co-authored-by: Wojciech Nawrocki <[email protected]>
Co-authored-by: Mario Carneiro <[email protected]>
EdAyers pushed a commit to leanprover-community/mathlib4 that referenced this issue Aug 18, 2022
@Vtec234 @digama0 @EdAyers
chore: update to nightly-2022-07-28 (#357)
12cdf0c 
Changed all names related to leanprover/lean4#1346 that I could find.

- [x] leanprover/lean4#1375

Co-authored-by: Wojciech Nawrocki <[email protected]>
Co-authored-by: Mario Carneiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vtec234