feat: generalize to arbitrary bitvec width zeroextend_bigger_smaller and truncate_of_concat_is_lsb
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i/LNsym into extend-arbitrary-bit-length
shigoel
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Thanks for the PR, @luisacicolini!
A high-level comment: could you please use LNSym's PR template for this PR's description?
|
thank you for reviewing this @shigoel! Everything should be fixed now. I removed |
alexkeizer
previously approved these changes
Oct 7, 2024
|
thanks @alexkeizer! I updated the theorem with your suggestions |
shigoel
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR extends
truncate_of_concat_is_lsb_64to arbitrary-width bitvectors.Testing:
What tests have been run? Did
make allsucceed for your changes? YesWas conformance testing successful on an Aarch64 machine? yes
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.