feat: add lake-manifest.json, update .gitignore #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've previously avoided having "empty" lake-manifest, because they are just a useless file to gitignore. However the absence causes a warning downstream, and this confusion to users is a more important consideration. |
kim-em
changed the title
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 6, 2024
Mathlib update corresponding to [Qq update PR 42](leanprover-community/quote4#42). The corresponding Qq PR added lake-manifest files into the repository. This PR updates mathlib to this commit of the PR. This PR addresses the warning message `warning: Qq: ignoring missing dependency manifest '././.lake/packages/Qq/lake-manifest.json'` when running `lake update` on a math project. For discussion see [this zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Qq.20manifest.20warning.20in.20new.20math.20project/near/437228437)
apnelson1
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 12, 2024
Mathlib update corresponding to [Qq update PR 42](leanprover-community/quote4#42). The corresponding Qq PR added lake-manifest files into the repository. This PR updates mathlib to this commit of the PR. This PR addresses the warning message `warning: Qq: ignoring missing dependency manifest '././.lake/packages/Qq/lake-manifest.json'` when running `lake update` on a math project. For discussion see [this zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Qq.20manifest.20warning.20in.20new.20math.20project/near/437228437)
callesonne
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2024
Mathlib update corresponding to [Qq update PR 42](leanprover-community/quote4#42). The corresponding Qq PR added lake-manifest files into the repository. This PR updates mathlib to this commit of the PR. This PR addresses the warning message `warning: Qq: ignoring missing dependency manifest '././.lake/packages/Qq/lake-manifest.json'` when running `lake update` on a math project. For discussion see [this zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Qq.20manifest.20warning.20in.20new.20math.20project/near/437228437)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, I have added lake-manifest.json by running
lake update. I have also updated.gitignoreto not ignore the manifest. If required, the .gitignore change can be undone.For relevant discussion see the linked zulip thread