Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: backport some simpler proofs from lean-pr-testing-6053 #19176

Closed
wants to merge 2 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Nov 17, 2024

A few things that break under leanprover/lean4#6053 admit nicer proofs anyway, so backport these more robust proofs.

Copy link

github-actions bot commented Nov 17, 2024

PR summary df090651a8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@j-loreaux
Copy link
Collaborator

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 18, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 18, 2024
A few things that break under leanprover/lean4#6053 admit nicer proofs anyway, so backport these more robust proofs.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: backport some simpler proofs from lean-pr-testing-6053 [Merged by Bors] - chore: backport some simpler proofs from lean-pr-testing-6053 Nov 18, 2024
@mathlib-bors mathlib-bors bot closed this Nov 18, 2024
@mathlib-bors mathlib-bors bot deleted the 6053_backports branch November 18, 2024 07:41
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
A few things that break under leanprover/lean4#6053 admit nicer proofs anyway, so backport these more robust proofs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants