Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: no need to pass autoParam to simp or dsimp #15968

Closed
wants to merge 1 commit into from

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Aug 19, 2024

and with leanprover/lean4#4154 it actually
complains, so let's remove them now.

and with leanprover/lean4#4154 it actually
complains, so let's remove them now.
Copy link

PR summary 01a72d43a3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@nomeata nomeata marked this pull request as ready for review August 19, 2024 09:49
@nomeata nomeata added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 19, 2024
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Aug 19, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 19, 2024
and with leanprover/lean4#4154 it actually
complains, so let's remove them now.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: no need to pass autoParam to simp or dsimp [Merged by Bors] - chore: no need to pass autoParam to simp or dsimp Aug 19, 2024
@mathlib-bors mathlib-bors bot closed this Aug 19, 2024
@mathlib-bors mathlib-bors bot deleted the joachim/simp-autoparam branch August 19, 2024 11:26
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
and with leanprover/lean4#4154 it actually
complains, so let's remove them now.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
and with leanprover/lean4#4154 it actually
complains, so let's remove them now.
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
and with leanprover/lean4#4154 it actually
complains, so let's remove them now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants