[Merged by Bors] - refactor(Data.Finset.Card): termination_by change #11370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will break once leanprover/lean4#3658 lands, so let's fix this now.
nomeata
added
awaiting-review
easy
|
Thanks! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by adomani. |
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
this will break once leanprover/lean4#3658 lands, so let's fix this now. Also avoids binding unused variables in `termination_by`.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
this will break once leanprover/lean4#3658 lands, so let's fix this now. Also avoids binding unused variables in `termination_by`.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
this will break once leanprover/lean4#3658 lands, so let's fix this now. Also avoids binding unused variables in `termination_by`.
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
this will break once leanprover/lean4#3658 lands, so let's fix this now. Also avoids binding unused variables in `termination_by`.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
this will break once leanprover/lean4#3658 lands, so let's fix this now. Also avoids binding unused variables in `termination_by`.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
this will break once leanprover/lean4#3658 lands, so let's fix this now. Also avoids binding unused variables in `termination_by`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will break once leanprover/lean4#3658
lands, so let's fix this now.
Also avoids binding unused variables in
termination_by.