[Merged by Bors] - feat: renaming symmetric MvPolynomials #11251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Junyan Xu <[email protected]>
eric-wieser
reviewed
Mar 8, 2024
Comment on lines
165
to
172
| /-- `MvPolynomial.rename` induces an isomorphism between the symmetric subalgebras. -/ | ||
| def rename_symmetricSubalgebra [CommSemiring R] (e : σ ≃ τ) : | ||
| symmetricSubalgebra σ R ≃ₐ[R] symmetricSubalgebra τ R := | ||
| AlgEquiv.ofAlgHom | ||
| (((rename e).comp (symmetricSubalgebra σ R).val).codRestrict _ <| fun x => x.2.rename e) | ||
| (((rename e.symm).comp <| Subalgebra.val _).codRestrict _ <| fun x => x.2.rename e.symm) | ||
| (AlgHom.ext <| fun p => Subtype.ext <| by simp) | ||
| (AlgHom.ext <| fun p => Subtype.ext <| by simp) |
There was a problem hiding this comment.
Do we have any kind of two-sided restriction for AlgEquivs? If not, do we have an API we could copy from LinearEquiv or RingEquiv or MulEquiv?
There was a problem hiding this comment.
Not that I could find quickly
eric-wieser
reviewed
Mar 8, 2024
eric-wieser
reviewed
Mar 8, 2024
eric-wieser
added
awaiting-author
Ruben-VandeVelde
added
awaiting-review
and removed
awaiting-author
|
bors merge |
github-actions
bot
added
ready-to-merge
YaelDillies
reviewed
Mar 24, 2024
|
bors r- |
|
Canceled. |
YaelDillies
approved these changes
Mar 24, 2024
|
bors merge |
|
bors delegate+ |
|
✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2024
Co-authored-by: Junyan Xu <[email protected]>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Louddy
pushed a commit
that referenced
this pull request
Mar 25, 2024
Co-authored-by: Junyan Xu <[email protected]>
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
Co-authored-by: Junyan Xu <[email protected]>
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Junyan Xu <[email protected]>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Co-authored-by: Junyan Xu <[email protected]>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Co-authored-by: Junyan Xu <[email protected]>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Junyan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Junyan Xu [email protected]