Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print first goal after safe prefix in terminal mode #139

Merged
merged 2 commits into from
May 24, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented May 22, 2024

When in terminal mode, print the (first) goal after the terminal prefix as part of the error message, so we get an indication of what progress aesop made, and where it got stuck.

Too often I write a structure where some auto_param field is not successfully filled in by aesop, and it's presumably just because a @[simp] lemma is missing. But to see the goal (and hence deduce the missing simp lemma), I have to add field := by aesop. I think with this change we'll just be able to see what we need immediately.

@kim-em kim-em requested a review from JLimperg May 22, 2024 08:06
@JLimperg JLimperg merged commit bbb5ab5 into master May 24, 2024
2 checks passed
@JLimperg JLimperg deleted the safe_prefix branch May 24, 2024 11:32
@JLimperg
Copy link
Collaborator

Ideas for improvements from our Zulip conversation:

  • Remove the "initial goal" part of the error message since it's usually not useful.
  • Collapse this part by default. (Needs core API changes; currently only trace nodes can be collapsed.)
  • Make an option to remove this part, off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants