Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adaptations for nightly-2024-03-11 #117

Closed
wants to merge 5 commits into from

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Mar 12, 2024

No description provided.

@kim-em
Copy link
Collaborator Author

kim-em commented Mar 12, 2024

@JLimperg, there are some test failures here, could you please take a look?

@JLimperg
Copy link
Collaborator

Fixed the test failures. The one nontrivial failure was due to some new simp lemmas about propositional logic. Specifically, simp is no longer able to reduce ∀ (a : α), ¬a ∈ head :: tail to False because it now rewrites

∀ (a : α), ¬(a = head ∨ a ∈ tail)
==>
∀ (a : α), ¬a = head ∧ ¬a ∈ tail

instead of

∀ (a : α), ¬(a = head ∨ a ∈ tail)
==> [forall_eq_or_imp]
False ∧ ∀ (a : α), a ∈ tail → False

I don't think the new normal form is bad or anything, but since we're abusing simp for logical reasoning a lot, any change like this will likely lead to some breakage.

@JLimperg
Copy link
Collaborator

Closing since this PR is superseded by #124.

@JLimperg JLimperg closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants