Merge pull request moby#4592 from jedevc/close-solver

chore: close solver resources on shutdown
leandrosansilva · Jan 26, 2024 · 23b9dd8 · 23b9dd8
2 parents 6bd8137 + 6337e81
commit 23b9dd8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/control/control.go b/control/control.go
@@ -130,11 +130,12 @@ func (c *Controller) Close() error {
 	if err := c.opt.WorkerController.Close(); err != nil {
 		rerr = multierror.Append(rerr, err)
 	}
-
 	if err := c.opt.CacheStore.Close(); err != nil {
 		rerr = multierror.Append(rerr, err)
 	}
-
+	if err := c.solver.Close(); err != nil {
+		rerr = multierror.Append(rerr, err)
+	}
 	return rerr
 }
 

diff --git a/solver/llbsolver/solver.go b/solver/llbsolver/solver.go
@@ -123,6 +123,12 @@ func New(opt Opt) (*Solver, error) {
 	return s, nil
 }
 
+func (s *Solver) Close() error {
+	s.solver.Close()
+	err := s.sysSampler.Close()
+	return err
+}
+
 func (s *Solver) resolver() solver.ResolveOpFunc {
 	return func(v solver.Vertex, b solver.Builder) (solver.Op, error) {
 		w, err := s.resolveWorker()