-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for advanced test lifecycle callbacks - setUpAll
#1751
Conversation
setUpAll
setUpAll
setUpAll
setUpAll
f879189
to
a84464f
Compare
Patrol's test bundling feature offloads scheduling&execution of tests to However, I think a workaround based on using
|
When should the setUpAll callbacks be run? The obvious answer is "before its tests start running". This means that Dart side has to know which Dart setUpAll callbacks have already run, and which not. This is a problem, because currently, the only synchronization point between instrumentation app and app under test is I made a playground where I'm testing how to bend package:test API to our use case. |
PlanTo discover To fix that, behavior of Dart tests must differ between the initial run and normal runs. Currently this behavior is mostly the same:
But to collect setUpAlls, this would have to happen:
|
21d4862
to
9edac16
Compare
Problem: not all tests are "falling through" during the initial run
5b742a3
to
56dca3b
Compare
…setLifecycleCallbacksState
…llbacksState Unfortunately it's failing for unknown reason (yet)
Before, PatrolServer.appReady was set once to true during the initial run, and it stayed like that in subsequent runs. This was a race conditions, and a temporary solution with 1 sec timeout was applied. Now the timeout is removed, and the logic should be fixed.
86715a6
to
d205d7a
Compare
21aafa2
to
b8f5bea
Compare
b8f5bea
to
6a6615e
Compare
Targeted at #1503.
See investigation conducted in #1741.