Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary spaces in Header & Footer #241

Merged

Conversation

h4rishabh
Copy link
Contributor

Removed unnecessary spaces from header & footer which looks weird.

Issue Fixed #

PR1

PR2

Removed unnecessary spaces from header & footer which looks weird.
@eiselems eiselems merged commit 51b998e into le4ker:master Jun 8, 2020
@eiselems
Copy link
Collaborator

eiselems commented Jun 8, 2020

Thanks for your contribution

@h4rishabh
Copy link
Contributor Author

Thanks for your contribution

Is is necessary to push cache files generated under path ⬇

*personal-jekyll-theme1.jekyll-cache\Jekyll\Cache\Jekyll--Cache\b7*

because footer didn't got loaded properly https://le4ker.github.io/personal-jekyll-theme/
(For which I gave the fix)

May I push the cache file again??

@eiselems
Copy link
Collaborator

I really think this isn't necessary, if I remember @le4ker set this repo up to serve from the gh-pages branch.
:
I merged your changed also there. See: #242

Think it looks better now: https://le4ker.github.io/personal-jekyll-theme/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants