Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gesture navigation to config fixes #170 #178

Merged
merged 1 commit into from
Jun 19, 2016
Merged

Conversation

eiselems
Copy link
Collaborator

@eiselems eiselems commented Jun 2, 2016

Issue Fixed #170

Proposed Changes

  • add possibility to disable the swipe navigation (including the instructions)

@eiselems eiselems changed the title Add possibility to disable gesture navigation in config #170 Add gesture navigation to config fixes #170 Jun 2, 2016
@eiselems
Copy link
Collaborator Author

eiselems commented Jun 3, 2016

The only thing left for discussion is how i did the disabling of everything. I don't know if for future enhancements it would be better to make it more specific. At the moment it disables all the page.section-type == "post" and page.section-type == "blog" scopes with one if-statement since the scopes only contain logic about the gestures / swiping instructions.
When this changes the if should be moved into the scopes resulting in multiple if-statements (one for each scope).

@le4ker
Copy link
Owner

le4ker commented Jun 19, 2016

It works! 👏

@le4ker le4ker merged commit 48e6137 into le4ker:master Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants