Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grayscale.scss #125

Merged
merged 1 commit into from
Jan 9, 2016
Merged

Update grayscale.scss #125

merged 1 commit into from
Jan 9, 2016

Conversation

joariasl
Copy link
Collaborator

min-height is the correct definition for not reduce the height if the parent size is less.

@le4ker
Copy link
Owner

le4ker commented Nov 25, 2015

Can you please post a screenshot with the repro? 😄

min-height is the correct definition for not reduce the height if the parent size is less.
@joariasl
Copy link
Collaborator Author

The problem is when the parent height is less that the div for swipe instruction.
I used a cyan color for show the difference.
Before:
screenshot from 2015-11-25 17-16-09
After:
screenshot from 2015-11-25 17-18-48

With the min-height propriety if the parent is less, the size use the auto content size, but if the parent is major, the div use the 100% of the parent size.

@joariasl
Copy link
Collaborator Author

I see that is necessary separate the container for the text of the post with the content for another content.

@le4ker
Copy link
Owner

le4ker commented Nov 26, 2015

And let's track is by an issue as well 😉

The workflow is:

  1. Open issue with repro steps and screenshot
  2. And then open the PL referencing the issue number 😉

I will try to see the PLs tonight, but I can't promise anything because I've been busy lately :(

Thanks!

le4ker pushed a commit that referenced this pull request Jan 9, 2016
@le4ker le4ker merged commit 789e21a into le4ker:master Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants