Add goto support -- pull still buggy #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify .hgignore to exclude PyCharm working dirs.
In general, changes made are: * Change constructor of Target to allow 'goto' option * Change create_target method of Rule, same purpose * Change how IPT_F_FRAG gets set in rule.entry.ip
So create_target()'s' goto parameter did not get passed to Target()... fixed.
|
Reading the Travis-CI fail above... So, I'll see what I can do to fix this, as soon as I can secure a box with IP6. |
Now properly use get_ip() and introspection to ensure compatibility with ip6tc, and future. (IPv8, anyone?)
|
Much apologies for two buggy pull requests. Please do not merge this one. I'm closing this one. |
pepoluan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch allows module to recognize "goto" (
-g) targets and create "goto" targets.This is a fix for #196
This fixes embarrassing bug on previous pull request.
Note: Unexpected behavior might be encountered if
goto=Trueis specified with a 'standard' target (e.g.,ACCEPT,DROP, etc.)